Invite lowercase emails to workspaces #7442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pecanoro
approved these changes
Jan 27, 2022
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
46 tasks
|
🚀 Deployed to production by @sketchydroide in version: 1.1.34-0 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We couldn't delete emails added with an uppercase, because then, when deleting, php side was trying to retrieve the email by key comparing it with lowercase. Let's just always add emails in lowercase
Fixed Issues
$ #7431
Tests
Invite an email with an uppercase letter to the workspace.
Make sure it's added with only lowercase letters.
Try to remove it. It should work
QA Steps
Invite an email with an uppercase letter to the workspace.
Make sure it's added with only lowercase letters.
Try to remove it. It should work
Tested On
Screenshots
Web