-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce imageHeight to windowHeight if greater #7388
Reduce imageHeight to windowHeight if greater #7388
Conversation
@sobitneupane Please add screenshots for other platforms. |
I have added for Web and mWeb. I don't have accessibility of macOS and IOS. |
It is because we have used 2 as scale to zoomin for doubleClick. It can be zoomed further using pinch-to-zoom.
|
Overall the PR looks good and I greatly appreciate the comments explaining the "why" of each bit of logic. Thanks! You've got some merge conflicts you need to resolve, but once that's done it will be good to go, IMO! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by @sketchydroide in version: 1.1.34-0 🚀
|
Details
Reduce height of image to height of window if it is greater than window's height.
Fixed Issues
$ #7012
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android