Fix error on iOS Payments page #7088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelvinBot
requested review from
stitesExpensify
and removed request for
a team
stitesExpensify
previously approved these changes
Jan 7, 2022
marcaaron
previously approved these changes
Jan 7, 2022
luacmartins
dismissed stale reviews from marcaaron and stitesExpensify
via
f9d5851
|
Updated! @stitesExpensify and I discussed 1:1 and the header should be sticky. I updated the solution to account for that. Here's the new behavior: new.behavior.mp4 |
marcaaron
approved these changes
Jan 7, 2022
6 tasks
stitesExpensify
approved these changes
Jan 7, 2022
|
Looks great! I'll merge when e2e ends in what I assume will be 3 hours :lolsob: |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
24 tasks
|
🚀 Deployed to staging by @stitesExpensify in version: 1.1.26-2 🚀
|
|
🚀 Deployed to staging by @stitesExpensify in version: 1.1.27-0 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.27-1 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Changes:
ScrollViewListHeaderComponentprop toPaymentMethodListFixed Issues
$ #7087
Tests
Settings > PaymentsQA Steps
Steps above.
Tested On
Screenshots
Web
web.mov
Mobile Web
mweb.mp4
Desktop
desktop.mov
iOS
ios.mp4
Android
android.mov