Changed the Amount Text to TextInput #6811
Conversation
|
@tgolen @parasharrajat I've found one issue with the Mobile Web. Even though I've added
Checking at my end |
|
Ops, I didn't notice that we have to handle M-Web as well.
Basically, this does not work for the Web. They are native props. |
|
|
|
@parasharrajat Thanks for the suggestion. This worked. |
src/pages/iou/steps/IOUAmountPage.js
Outdated
| this.unsubscribeAppStateSubscription(); | ||
| } | ||
|
|
||
| handleAppStateChange(nextAppState) { |
There was a problem hiding this comment.
Methods need to be named for what they do rather than for what they handle. I suggest renaming this to dismissKeyboardWhenBackgrounded
…ount-pasting # Conflicts: # src/pages/iou/steps/IOUAmountPage.js
|
@tgolen PR updated |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
| if (!this.unsubscribeAppStateSubscription) { | ||
| return; | ||
| } | ||
| this.unsubscribeAppStateSubscription(); |
There was a problem hiding this comment.
This function does not return a method to unsubscribe...
There was a problem hiding this comment.
this.unsubscribeAppStateSubscription.remove()
There was a problem hiding this comment.
Ah yes, good catch. I am seeing some console errors for this. @akshayasalvi can you please fix this?
There was a problem hiding this comment.
Hi,
Okay sure. I'll do that.
There was a problem hiding this comment.
No worries, we've fixed it already. This was taken care of in #6909
There was a problem hiding this comment.
Thanks for the help
|
🚀 Deployed to production by @francoisl in version: 1.1.24-8 🚀
|
| if (!nextAppState.match(/inactive|background/)) { | ||
| return; | ||
| } | ||
| Keyboard.dismiss(); |
There was a problem hiding this comment.
👋 Coming from #26505
Keyboard.dismiss was added as a fix #6285 (comment) where in native, showSoftInputOnFocus does not work if the app is backgrounded, then foregrounded
This was causing #26505 on Desktop
We resolved this by moving this logic to a platform-specific file, so it's called only on native platforms (since this bug is present only on native)
There was a problem hiding this comment.
I love that. Thank you for moving it to a platform-specific file!
Details
IOUAmountfieldFixed Issues
$ #6285
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
ios-amount-pasting.mov
Android