Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #6738 from azimgd/fix-reverted-list" #6795

Closed
wants to merge 1 commit into from

Conversation

alex-mechler
Copy link
Contributor

This reverts commit 1c80150, reversing
changes made to 7b0752d.

cc @azimgd

Details

This inverted flatlist fix broke iOS and Android views with a few amount of messages

Fixed Issues

$ #6792

Tests

  1. Launch the app
  2. Log in
  3. Tap on Fab menu and Tap on New Room
  4. Create a Room
  5. Send some messages
  6. Verify they appear at the bottom

QA Steps

  1. Launch the app
  2. Log in
  3. Tap on Fab menu and Tap on New Room
  4. Create a Room
  5. Send some messages
  6. Verify they appear at the bottom

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

image

This reverts commit 1c80150, reversing
changes made to 7b0752d.
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team December 16, 2021 02:01
@alex-mechler alex-mechler removed the request for review from jasperhuangg December 16, 2021 02:01
Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so that we can resolve the deploy blocker

@azimgd
Copy link
Contributor

azimgd commented Dec 16, 2021

@alex-mechler @Julesssss Can we prioritize the fix #6798 instead ?

cc @thienlnam

@Julesssss
Copy link
Contributor

@azimgd ah, thanks for pointing that out. I'll review it once I have a moment.

@alex-mechler
Copy link
Contributor Author

Yup, we can do that instead! Thanks for working on a fix for this so quick!

@Julesssss Julesssss deleted the amechler-revert-flatlist-invert branch December 16, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants