Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA]Sign cherry pick PRs as @OSBotify #6655

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Conversation

AndrewGable
Copy link
Contributor

@AndrewGable AndrewGable commented Dec 8, 2021

Details

This PR should sign our cherry pick commits and make all the cherry picks created by @OSBotify. This is the last step to forcing signatures for all commits.

Fixed Issues

$ GH_LINK

Tests

  1. Merge this PR with the CP label and the QA checklist locked
  2. Make sure the commits to the staging branch are signed and verified
  3. Once 2 is confirmed, create a test CP with a dummy change to CP manually

@AndrewGable AndrewGable self-assigned this Dec 8, 2021
@AndrewGable AndrewGable requested a review from a team as a code owner December 8, 2021 23:33
@MelvinBot MelvinBot requested review from danieldoglas and removed request for a team December 8, 2021 23:33
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we also add manual cherry-picking to the test list just to confirm that all still works?

@@ -89,7 +86,6 @@ jobs:

- name: Create branch for new pull request
run: |
git config user.name ${{ github.actor }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will fail if we don't specify a user name. I think we need to hardcode it to OSBotify if we want all CP commits to be done + signed by OSBotify:

git config user.name 'OSBotify'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@roryabraham
Copy link
Contributor

Let's see if this works

@roryabraham roryabraham merged commit 7068258 into main Dec 9, 2021
@roryabraham roryabraham deleted the andrew-sign-cp branch December 9, 2021 22:23
OSBotify pushed a commit that referenced this pull request Dec 9, 2021
@roryabraham
Copy link
Contributor

Seems like it worked for a label CP:

image

@roryabraham
Copy link
Contributor

Testing this with a manual CP of #6684

@roryabraham
Copy link
Contributor

This seemed to work with a manual CP as well 🎉

image

@AndrewGable
Copy link
Contributor Author

Awesome!! Thank you for testing this!

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.1.19-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants