Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍒 Cherry pick PR #6259 to staging 🍒 #6571

Merged
merged 3 commits into from
Dec 3, 2021

Conversation

OSBotify
Copy link
Contributor

@OSBotify OSBotify commented Dec 3, 2021

🍒 Cherry pick #6259 to staging 🍒

OSBotify and others added 2 commits December 3, 2021 01:34
…fec6ae9a795c4febfa4b6d846

(cherry picked from commit 0311b18)
[PlaidLink OAuth] Add web redirect_uri to `/bank-accounts` page

(cherry picked from commit 85799c2)
@OSBotify
Copy link
Contributor Author

OSBotify commented Dec 3, 2021

This pull request has merge conflicts and can not be automatically merged. 😞
Please manually resolve the conflicts, push your changes, and then request another reviewer to review and merge.
Important: There may be conflicts that GitHub is not able to detect, so please carefully review this pull request before approving.

@nickmurray47
Copy link
Contributor

nickmurray47 commented Dec 3, 2021

*conflict was in ReimbursementAccountPage, I think I pulled down and merged changes that were not on staging yet

I pulled and merged main with the original PR, but it seems like ../../components/ExpensifyText is still just ../../components/Text on staging so reverted back to ../../components/Text

@marcaaron
Copy link
Contributor

LGTM

@marcaaron marcaaron merged commit 0f77bef into staging Dec 3, 2021
@marcaaron marcaaron deleted the OSBotify-cherry-pick-staging-6259 branch December 3, 2021 02:22
@OSBotify
Copy link
Contributor Author

OSBotify commented Dec 3, 2021

🚀 Cherry-picked to staging by @marcaaron in version: 1.1.17-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@marcaaron marcaaron added the DeployBlockerCash This issue or pull request should block deployment label Dec 3, 2021
@marcaaron
Copy link
Contributor

@nickmurray47 actually I think the URL config change borked stuff. I have double forward slashes when testing staging.

2021-12-03_07-08-12

@marcaaron
Copy link
Contributor

Sending a PR now.

@nickmurray47
Copy link
Contributor

Ah crap

@isagoico
Copy link

isagoico commented Dec 3, 2021

@nickmurray47 @marcaaron We were testing this CP on our side as well - should I hold testing since this be tested internally?

@nickmurray47
Copy link
Contributor

@isagoico yes, I think this will be tested internally.

@nickmurray47
Copy link
Contributor

This passes our sandbox QA on staging @isagoico

Screen Shot 2021-12-03 at 11 45 14 AM

@marcaaron marcaaron removed the DeployBlockerCash This issue or pull request should block deployment label Dec 3, 2021
@OSBotify
Copy link
Contributor Author

OSBotify commented Dec 6, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants