Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Fix const import on staging #6483

Merged
merged 1 commit into from
Nov 26, 2021
Merged

[No QA] Fix const import on staging #6483

merged 1 commit into from
Nov 26, 2021

Conversation

luacmartins
Copy link
Contributor

Details

Import CONST in EnableStep to fix staging.

Fixed Issues

$ #6482

Tests

N/A

QA Steps

N/A

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@luacmartins luacmartins requested a review from a team as a code owner November 25, 2021 22:13
@luacmartins luacmartins self-assigned this Nov 25, 2021
@luacmartins luacmartins removed the request for review from a team November 25, 2021 22:13
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

danieldoglas
danieldoglas approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@danieldoglas danieldoglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luacmartins luacmartins removed the request for review from sketchydroide November 25, 2021 22:20
@luacmartins luacmartins merged commit 4d0a82e into main Nov 26, 2021
@luacmartins luacmartins deleted the cmartins-fixCONSTimport branch November 26, 2021 00:56
@luacmartins
Copy link
Contributor Author

Self-merged with approval!

github-actions bot pushed a commit that referenced this pull request Nov 26, 2021
@luacmartins
Merge pull request #6483 from Expensify/cmartins-fixCONSTimport
ffc4a73 
[No QA] Fix const import on staging

(cherry picked from commit 4d0a82e)
@OSBotify OSBotify mentioned this pull request Nov 26, 2021
Merged
luacmartins added a commit that referenced this pull request Nov 26, 2021
@luacmartins
Merge pull request #6494 from Expensify/OSBotify-cherry-pick-staging-…
7561318 
…6483

🍒 Cherry pick PR #6483 to staging 🍒
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @luacmartins in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Nov 29, 2021
Closed
69 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @luacmartins in version: 1.1.16-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 6, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldoglas danieldoglas danieldoglas approved these changes

Assignees

@luacmartins luacmartins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luacmartins @OSBotify @danieldoglas