-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode secondary login URL #6479
Conversation
|
Encode secondary login URL (cherry picked from commit dd291dc)
@luacmartins hello! I think there were some conflicts while merging, we're not seeing build 1.1.16-9 #6481 (comment) |
…6479 🍒 Cherry pick PR #6479 to staging 🍒
🚀 Cherry-picked to staging by @madmax330 in version: 1.1.16-9 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
App is crashing on iOS and Android when tapping on "Add work email..." button. Video below crash.mp4 |
🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀
|
🚀 Deployed to staging by @madmax330 in version: 1.1.16-11 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀
|
Details
iOS treats URL encoding a bit differently and I had to adjust it to be able to deeplink into the secondary login page in OldDot.
Fixed Issues
$ #6475
Tests
QA Steps
Tested On
Screenshots
Web
web.mov
Mobile Web
mweb.mov
Desktop
desktop.mov
iOS
ios.mov
Android
android.mov