Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra margin #6466

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Remove extra margin #6466

merged 1 commit into from
Nov 29, 2021

Conversation

parasharrajat
Copy link
Member

Details

Fixed Issues

$ #6460

Tests | QA Steps

  1. Open the Add secondary Login Page from Profile Screen.
  2. Observe the margin under the Send validation button.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop | Mobile Web | IOS | native

image

@parasharrajat parasharrajat marked this pull request as ready for review November 25, 2021 08:09
@parasharrajat parasharrajat requested a review from a team as a code owner November 25, 2021 08:09
@botify botify requested a review from deetergp November 25, 2021 08:09
@MelvinBot MelvinBot requested review from deetergp and removed request for a team and deetergp November 25, 2021 08:09
@parasharrajat
Copy link
Member Author

Awaiting your review @deetergp Thanks. Should be quick...

deetergp
deetergp approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@deetergp deetergp merged commit 1edb7ee into Expensify:main Nov 29, 2021
@OSBotify OSBotify mentioned this pull request Nov 29, 2021
Closed
69 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @deetergp in version: 1.1.16-12 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 6, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the secondaryPage branch November 20, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deetergp deetergp deetergp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parasharrajat @OSBotify @deetergp