Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing #32409 (part2) #6440

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Testing #32409 (part2) #6440

merged 1 commit into from
Nov 23, 2021

Conversation

pecanoro
Copy link
Contributor

Details

Fixed Issues

$ https://github.com/Expensify/Web-Expensify/pull/32409

Tests

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@pecanoro pecanoro requested a review from a team as a code owner November 23, 2021 19:47
@pecanoro pecanoro self-assigned this Nov 23, 2021
@pecanoro pecanoro changed the title Testing #32409 part2 Testing #32409 (part2) Nov 23, 2021
@pecanoro pecanoro removed the request for review from a team November 23, 2021 19:47
@pecanoro pecanoro removed the request for review from jasperhuangg November 23, 2021 19:47
@pecanoro pecanoro added the InternalQA This pull request required internal QA label Nov 23, 2021
chiragsalian
chiragsalian approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@chiragsalian chiragsalian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard review but LGTM

@pecanoro pecanoro merged commit 5bf393b into main Nov 23, 2021
@pecanoro pecanoro deleted the pecanoro-patch-1 branch November 23, 2021 21:54
@MelvinBot
Copy link

Triggered auto assignment to @MariaHCD (InternalQA), see https://stackoverflow.com/c/expensify/questions/5042 for more details.

@botify
Copy link

botify commented Nov 23, 2021

@pecanoro looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@pecanoro
Copy link
Contributor Author

No way @botify , they show as passed for me

Testing #32409 (part2) by pecanoro · Pull Request #6440 · Expensify:App 2021-11-23 16-56-11

@OSBotify OSBotify mentioned this pull request Nov 29, 2021
Closed
69 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @pecanoro in version: 1.1.16-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 6, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwenmemon yuwenmemon yuwenmemon approved these changes

@chiragsalian chiragsalian chiragsalian approved these changes

Assignees

@pecanoro pecanoro

@MariaHCD MariaHCD

Labels
InternalQA This pull request required internal QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pecanoro @MelvinBot @botify @OSBotify @yuwenmemon @chiragsalian @MariaHCD