[No QA] Update webpack so the apple association file is served from .well-known directory #6430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
marcaaron
approved these changes
Nov 23, 2021
marcaaron
reviewed
Nov 23, 2021
| @@ -51,7 +51,7 @@ const webpackConfig = { | |||
| {from: 'assets/css', to: 'css'}, | |||
| {from: 'node_modules/react-pdf/dist/esm/Page/AnnotationLayer.css', to: 'css/AnnotationLayer.css'}, | |||
| {from: 'assets/images/shadow.png', to: 'images/shadow.png'}, | |||
| {from: '.well-known/apple-app-site-association'}, | |||
| {from: '.well-known/apple-app-site-association', to: '.well-known/apple-app-site-association'}, | |||
There was a problem hiding this comment.
NAB, probably we can just copy the whole .well-known directory
{from: '.well-known'},but what you have is also fine.
69 tasks
|
🚀 Deployed to staging by @marcaaron in version: 1.1.16-11 🚀
|
5 tasks
|
🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This fixes the path for the apple-app-association file in webpack, since the webpack build did not serve the file from
.well-knowndirectory. Tests on staging shown the apple validator tool is not able to locate the file #6385 (comment).If the
tokey is omitted from the option, the default is the root directory so the file is not served from.well-known/directory as it should https://webpack.js.org/plugins/copy-webpack-plugin/#tos2019.Fixed Issues
Related to #6385
Tests
Run
npm run desktop-buildlocally and confirm no errors happen.QA
None
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android