Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip prefix and translate pronouns when needed #6419

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Strip prefix and translate pronouns when needed #6419

merged 1 commit into from
Nov 23, 2021

Conversation

Gonals
Copy link
Contributor

@Gonals Gonals commented Nov 23, 2021 •
edited
Loading

Details

Small change to make sure we correctly display the pronouns. Thanks @parasharrajat for proposing the solution

Fixed Issues

$ #6416

Tests/ QA Steps

  1. Start a new conversation in Newdot with someone you have never chatted with that has pronouns set.
  2. Make sure the pronouns are correctly displayed:

Screen Shot 2021-11-23 at 3 37 51 PM

Tested On

  • Web
  • [] Mobile Web
  • Desktop
  • iOS
  • Android

@Gonals Gonals requested a review from a team November 23, 2021 14:38
@Gonals Gonals self-assigned this Nov 23, 2021
@MelvinBot MelvinBot requested review from chiragsalian and removed request for a team November 23, 2021 14:38
@Beamanator Beamanator self-requested a review November 23, 2021 14:55
Beamanator
Beamanator approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! :shipit:

Screen Shot 2021-11-23 at 4 56 09 PM

@parasharrajat
Copy link
Member

CP it.

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@Beamanator Beamanator merged commit 1e88ca5 into main Nov 23, 2021
@Beamanator Beamanator deleted the alberto-fixPronouns branch November 23, 2021 15:37
github-actions bot pushed a commit that referenced this pull request Nov 23, 2021
@Beamanator
Merge pull request #6419 from Expensify/alberto-fixPronouns
b8001c0 
Strip prefix and translate pronouns when needed

(cherry picked from commit 1e88ca5)
This was referenced Nov 23, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @Beamanator in version: 1.1.16-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify OSBotify mentioned this pull request Nov 29, 2021
Closed
69 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Beamanator in version: 1.1.16-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 6, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Beamanator Beamanator Beamanator approved these changes

@chiragsalian chiragsalian Awaiting requested review from chiragsalian

Assignees

@Gonals Gonals

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gonals @parasharrajat @OSBotify @Beamanator