Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Update webpack path for apple app association #6408

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Nov 22, 2021

Details

This fixes the path for the apple-app-association file in webpack, which is causing GH actions failures on desktop

Fixed Issues

Related to #6385

Tests

Run npm run desktop-build locally and confirm no errors happen.

QA

None

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@Jag96 Jag96 requested a review from mountiny November 22, 2021 21:07
@Jag96 Jag96 self-assigned this Nov 22, 2021
@Jag96 Jag96 requested a review from a team as a code owner November 22, 2021 21:07
@botify
Copy link

botify commented Nov 22, 2021

Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work?

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from Dal-Papa and removed request for a team November 22, 2021 21:08
@chiragsalian
Copy link
Contributor

chiragsalian commented Nov 22, 2021

Will you also fix the error, from here

/Users/runner/work/App/App/src/libs/actions/User.js
Error:   284:10  error  'subscribeToExpensifyCardUpdates' is defined but never used  no-unused-vars

in this PR?

Edit: NVM me it looks like the most recent actions are passing just fine on this.

@Jag96 Jag96 merged commit 6b34f86 into main Nov 22, 2021
@Jag96 Jag96 deleted the joe-update-webpack branch November 22, 2021 22:08
github-actions bot pushed a commit that referenced this pull request Nov 22, 2021
[No QA] Update webpack path for apple app association

(cherry picked from commit 6b34f86)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @Jag96 in version: 1.1.16-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.1.16-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 6, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants