Ensures mini actions menu will disappear when attachment modal opens up

[sidferreira]

Details

The ={false} value of the prop was forcing the mini action menu to keep visible even when it lost the focus.

Fixed Issues

#5972

Tests

When tapping to open the attachment, should NOT show the mini actions menu after closing the attachments modal

QA Steps

1. Navigate to a conversation
2. Send an image
3. Open the image preview
4. Click on the top right X to close the modal
5. Close the modal

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Recording

• Web https://www.dropbox.com/s/vt1vat6ib52bcb7/MINI_ACTION_TEST_WEB.mp4?dl=0
• Mobile Web https://www.dropbox.com/s/78icy876lrzodxq/MINI_ACTION_TEST_WEB_IOS.mp4?dl=0
• Desktop https://www.dropbox.com/s/8v8hmkrfbj7046t/MINI_ACTION_TEST_DESKTOP.mp4?dl=0
• iOS https://www.dropbox.com/s/6j9ofxvtrjuncnm/MINI_ACTION_IOS.mp4?dl=0
• Android https://www.dropbox.com/s/jmax9etffmz3k9g/MINI_ACTIONS_ANDROID.mp4?dl=0

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[sidferreira]

I have read the CLA Document and I hereby sign the CLA

[pecanoro]

Could you post a small video to show that it's working? Since it actually has a visual effect, but obviously it cannot be seen with a screenshot.

[sidferreira]

@pecanoro done

[parasharrajat]

@sidferreira Could you upload videos for all platforms mentioned on the template?
More importantly, trigger delete message action from Right Click Context Menu and Mini-action menu.

Your videos should reflect:

1. Mini action menu behavior.
2. Right-click Context Menu behavior.
3. Delete message action modal. Closing this modal via Escape key etc,

[sidferreira]

@parasharrajat Updated

[parasharrajat]

Thanks for uploading those. It would help us review this PR faster.
Did you test Right-click Context Menu behavior?

I will test this later.

[sidferreira]

@parasharrajat @mallenexpensify Did the test, but not sure if recorded them (recording was made after the tests/pr)

[parasharrajat]

Thanks, I will test it today in a few hours.

[parasharrajat]

LGTM, Tested on the web. Works well.

[parasharrajat]

All yours @pecanoro

[OSBotify]

@sidferreira, Great job getting your first Expensify/App pull request over the finish line! 🎉

I know there's a lot of information in our contributing guidelines, so here are some points to take note of 📝:

1. Now that your first PR has been merged, you can be hired for another issue. Once you've completed a few issues, you may be eligible to work on more than one job at a time.
2. Once your PR is deployed to our staging servers, it will undergo quality assurance (QA) testing. If we find that it doesn't work as expected or causes a regression, you'll be responsible for fixing it. Typically, we would revert this PR and give you another chance to create a similar PR without causing a regression.
3. Once your PR is deployed to production, we start a 7-day timer ⏰. After it has been on production for 7 days without causing any regressions, then we pay out the Upwork job. 💰

So it might take a while before you're paid for your work, but we typically post multiple new jobs every day, so there's plenty of opportunity. I hope you've had a positive experience contributing to this repo! 😊

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @pecanoro in version: 1.1.13-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @Jag96 in version: 1.1.14-4 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[parasharrajat]

Oops, I didn't notice that this PR didn't have signed commits. I am not sure what should we do now?

[pecanoro]

@parasharrajat oh interesting, I didn't notice either, in our other repos, we block people from being able to merge PRs with unsigned commits, we should definitely enable that here too.

[parasharrajat]

Yeah, I raised this in the Slack. Let's put this suggestion there.

[sidferreira]

@parasharrajat should I sign this too?

[parasharrajat]

I think this is not possible now. It is merged so skip this unless someone raises a flag.

[ogumen]

Accessibility issues found in this PR:

1. Keyboard Navigation: New Chat: The invisible clickable message is focusable with tab key - failure of WCAG SC 2.4.3, similar to [med] Keyboard Navigation: Many Pages: Invisible button is focused with Tab key #5452
   https://user-images.githubusercontent.com/88733897/142638431-2e3277c0-91bc-46f3-8b8e-982f5fbf9740.mp4
2. Keyboard Navigation: Chat: Focus order through messages is reversed bottom-to-top - failure of WCAG SC 2.4.3, same as [med] Keyboard Navigation: Chat: Focus order through messages is reversed bottom-to-top #5676
3. The image attachment does not have a visible outline on focus - failure of WCAG SC 2.4.7
   https://user-images.githubusercontent.com/88733897/142766775-7575d720-9e65-4a6a-9f86-a2a05ca09b98.mp4
4. The image attachment cannot be focused with Tab key when the screen reader is enabled - failure of WCAG SC 2.1.1
   https://user-images.githubusercontent.com/88733897/142766965-407741e9-e8c9-4101-8e85-374614a14f6c.mp4
5. The "Download attachment" button is announced without button role and with no context, as "Attachment" - failure of WCAG SC 4.1.2, similar to [med] JAWS+Chrome: Many Pages: Multiple elements announced without button role #5446 and [med] JAWS+Chrome: Many Pages: Multiple buttons announced without labels #5519
   https://user-images.githubusercontent.com/88733897/142767093-92a98a7c-9f18-4f73-8b9f-f6e7075cc41e.mp4
6. The non-interactive dialog title is focusable with Tab key - failure of WCAG SC 2.4.3
   https://user-images.githubusercontent.com/88733897/142767239-77f22450-8003-4389-82b4-043f4613c42b.mp4
7. The zoom-in and zoom-out functionality is not available for screen reader users - failure of WCAG SC 2.1.1
   https://user-images.githubusercontent.com/88733897/142767259-469da5e0-05fb-405f-b302-866fc5ba1925.mp4
8. The "Close" and "Download attachment" buttons in the opened image attachment modal dialog do not meet the minimum color contrast requirements of 3.0:1. The grey buttons (#C6C9CA) against white background (#FFFFFF) have a color contrast ratio of 1.66:1 - failure of WCAG SC 1.4.11
   
9. The image attachment modal dialog has no programmatic label - failure of WCAG SC 1.3.1
   
10. The visual "Attachment" heading in the image attachment dialog is not implemented programmatically as a heading - failure of SCAG SC 1.3.1, similar to [low] JAWS+Chrome: Many Pages: Visual headings are not announced as such #5458
    

[stitesExpensify]

FYI we're going to revert this, I will make the same change myself so that it is signed, and then we're going to merge that PR. No action required on your parts @parasharrajat @sidferreira. Thanks for bringing it up and we'll keep a closer eye on this moving forward until we make it a requirement for the repo 😄