Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Quick copy update to the VBANoECard message #5882

Merged
merged 2 commits into from
Oct 15, 2021

Conversation

trjExpensify
Copy link
Contributor

Details

The copy is wrong in the VBANoECard message scenario, it should read: Add a work email address to issue unlimited Expensify Cards for your workspace members, as well as all of these incredible benefits:

I've also updated the Spanish based on this thread.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/181178

Tests

None

QA Steps

  1. Sign-up to NewDot with a public email address
  2. Click the + icon and New workspace
  3. Click connect bank account and connect manually
  4. Add a VBA (#2 in this SO)
  5. Validate the three amounts to complete the flow
  6. Verify that this copy is displayed on the Issue corporate cards page of the workspace editor:

Header: Unlock free Expensify Cards
Copy: Add a work email address to issue unlimited Expensify Cards for your workspace members, as well as all of these incredible benefits:

  • Up to 2% cash back
  • Digital and physical cards
  • No personal liability
  • Customizable limits

Concierge can help you add a work email address to enable the Expensify Card.
Button: [Chat with Concierge]

Tested On

None

@trjExpensify trjExpensify self-assigned this Oct 15, 2021
@trjExpensify trjExpensify requested a review from a team as a code owner October 15, 2021 11:37
@MelvinBot MelvinBot requested review from Luke9389 and removed request for a team October 15, 2021 11:37
@trjExpensify trjExpensify removed the request for review from Luke9389 October 15, 2021 11:37
@iwiznia iwiznia merged commit ee77c85 into main Oct 15, 2021
@iwiznia iwiznia deleted the trjExpensify-VBANoECard-copy-update branch October 15, 2021 12:30
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @iwiznia in version: 1.1.7-27 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants