Only deactivate label if field isn't focused #5789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mountiny
approved these changes
Oct 12, 2021
|
Feel free to self-merge once the E2E tests will pass and you will see it before me 😄 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
I think this PR may be the culprit for this issue #5904 |
|
Please note that the entry format for some fields is conveyed using placeholder only, and the placeholder text disappears once user enters any character into the field. It is mandatory to display the permanently visible instructions when user entry is required (WCAG SC 3.3.2). The issue is mentioned in #5703 (comment) |
|
🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes an issue where the Expensitext label value will move over the cursor after deleting the content but keeping focus. In the case that the input has a label and a placeholder, this looks especially bad (see https://github.com/Expensify/Expensify/issues/180809).
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/180809
Tests/QA
Issue Corporate Cardsand thenConnect Bank Account. Fill out anything for the values onConnect Bank Accountand submit to get to theCompany InformationstepCompany Informationstep, the phone number placeholder doesn't overlap the label like in https://github.com/Expensify/Expensify/issues/180809 when you enter a value and then remove the valueTested On
Screenshots