-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only show fancy loading page when we are submitting verifications #5787
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of missing displayNames. Running though tests now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass fine, once comments are address this is 👍
Only show fancy loading page when we are submitting verifications (cherry picked from commit 397510d)
🚀 Cherry-picked to staging by @marcaaron in version: 1.1.7-11 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Tested this today on web and it worked like a charm, no interstitial when jumping into the flow, entering routing/account number, or entering validate step info 👍 |
🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀
|
🚀 Deployed to staging by @marcaaron in version: 1.1.7-25 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀
|
Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/180798
Tests / QA Steps
PENDING
instructions here)Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android