Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Avatar styles on the chat UI #5786

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Fix: Avatar styles on the chat UI #5786

merged 1 commit into from
Oct 12, 2021

Conversation

parasharrajat
Copy link
Member

Details

#5756 (comment)

Fixed Issues

$ #5756

Tests | QA Steps

  1. Navigate to a conversation
  2. Send a long message that takes at least a 5 lines (could be a long image)
  3. Click on the blank area left to the message and below the avatar

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Mobile Web

Screenshot 2021-10-13 00:45:19

Web | Desktop

image

iOS

Android

Screenshot 2021-10-13 00:44:32

@parasharrajat parasharrajat requested a review from a team as a code owner October 12, 2021 19:16
@MelvinBot MelvinBot requested review from thienlnam and removed request for a team October 12, 2021 19:16
@parasharrajat
Copy link
Member Author

@thienlnam Ready to merge. 😃

@thienlnam thienlnam merged commit 8418368 into Expensify:main Oct 12, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Oct 15, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @thienlnam in version: 1.1.7-25 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify botify mentioned this pull request Oct 23, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thienlnam thienlnam thienlnam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parasharrajat @OSBotify @thienlnam