Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add period to Bill Pay copy #5780

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Add period to Bill Pay copy #5780

merged 1 commit into from
Oct 13, 2021

Conversation

stitesExpensify
Copy link
Contributor

Details

Literally just adding a period

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/180848

Tests

  1. Create a workspace (or go to an existing one)
  2. Go to Pay bills tab

QA Steps

  1. Create a workspace
  2. Go to Pay bills tab

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

2021-10-12_11-52-37

@stitesExpensify stitesExpensify self-assigned this Oct 12, 2021
@stitesExpensify stitesExpensify requested a review from a team as a code owner October 12, 2021 17:53
@MelvinBot MelvinBot requested review from MariaHCD and removed request for a team October 12, 2021 17:53
@kevinksullivan kevinksullivan changed the title Add period to invoice copy Add period to Bill Pay copy Oct 12, 2021
@MariaHCD MariaHCD merged commit e0affe4 into main Oct 13, 2021
@MariaHCD MariaHCD deleted the stites-updateManageBillsCopy branch October 13, 2021 04:36
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @MariaHCD in version: 1.1.7-25 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@ogumen
Copy link

ogumen commented Oct 22, 2021

  1. The "Manage your bills" and "Unlock online bill payment" are implemented as plain text, although visually they are headings. Failure of WCAG SC 1.3.1, similar to [low] JAWS+Chrome: Many Pages: Visual headings are not announced as such #5458
    Expensify_Pay bills_Visual headings implemented as plain text
  2. Link "View all bills" not announced as opening in a new window (the icon conveying this fact is not announced by screen reader). Failure of 1.1.1, similar to [low] JAWS+Chrome: About: Links not announced as opening in a new tab/page #5653
    Expensify_Pay bills_Link opening in a new tab does not convey the same
  3. The email link is identified by use of color alone, failure of WCAG SC 1.4.1, similar to [med] Color: Many Pages: Only color is used to distinguish links on the page #5447
    Expensify_Pay bills_The link is identified by use of color alone
  4. The focus is not trapped in the Pay bills dialog and the background page elements can be focused. Failure of WCAG SC 2.4.3, similar to [med] Keyboard Navigation: Many Pages: Focus not moved/trapped within the opened dialog #5516
    Expensify_Pay bills_Focus not trapped in the dialog
  5. The grey Back and Close buttons, as well as icon conveying the link opens in a new tab (#C6C9CA) on white background (#FFFFFF) have a color contrast of 1.91:1 failing the minimum contrast requirements of 3.00:1.
    Expensify_Pay bills_Grey icons on white background fail contrast requirements
  6. The "View all bills" link is announced without link role, the "Connect bank account" button is announced with no button role. Failure of WCAG SC 4.1.2, similar to [med] JAWS+Chrome: Many Pages: Multiple elements announced without button role #5446 and [med] JAWS+Chrome: About: Several links announced without link role #5459
    Expensify_Pay bills_Interactive elements announced without any role

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants