Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show growl when clicking on links in offline mode #5776

Merged
merged 9 commits into from
Oct 12, 2021

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented Oct 12, 2021

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/180868

Tests / QA

  1. Go to settings > about
  2. Verify the external links work
  3. Go offline
  4. Click on an external link
  5. Verify that you see a growl
  6. Go back online
  7. Click on an external link
  8. Verify that they work
  9. Repeat step 2-8 on Settings > Workspace > (any external link to OldDot on any of these pages like view bills or view invoices)

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

Desktop

image

iOS

image

Android

@tgolen tgolen self-assigned this Oct 12, 2021
@tgolen tgolen requested a review from a team October 12, 2021 17:38
@tgolen tgolen marked this pull request as ready for review October 12, 2021 17:38
@MelvinBot MelvinBot removed the request for review from a team October 12, 2021 17:38
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@tgolen tgolen requested a review from a team as a code owner October 12, 2021 17:42
@MelvinBot MelvinBot requested review from aldo-expensify and removed request for a team October 12, 2021 17:42
@tgolen tgolen removed the request for review from HorusGoul October 12, 2021 17:51
@aldo-expensify
Copy link
Contributor

aldo-expensify commented Oct 12, 2021

Not sure if this is out of the scope, but trying to create the workspace when offline doesn't give feedback:

Screen.Recording.2021-10-12.at.11.07.57.AM.mov

It seems like the workspaces were created anyway:

Screen Shot 2021-10-12 at 11 12 43 AM

@aldo-expensify
Copy link
Contributor

aldo-expensify commented Oct 12, 2021

When offline, if follow:

  • Workspace > Issue corporate cards > Connect bank account, or
  • Workspace > Reimburse receipts > Connect bank account

you get to a page with the text: "We’re taking a look at your information. You will be able to continue with next steps shortly." and without a button to go back on the top.

This message is incorrect for this situation, right?

Screen.Recording.2021-10-12.at.11.16.02.AM.mov

@tgolen
Copy link
Contributor Author

tgolen commented Oct 12, 2021

Thanks, @aldo-expensify. The workspace creation is out-of-scope for this, yeah. You might want to bring it up in the N6 room on slack though.

The issue with the bank account page is also out-of-scope and being discussed over here in slack.

@aldo-expensify
Copy link
Contributor

I guess this may be out of the scope, but leaving a comment to remember. The "Manage members" doesn't work well offline, members get added locally, but there is not feedback. Trying again results in an error of adding a member that is already there.

Screen.Recording.2021-10-12.at.11.23.49.AM.mov

@tgolen
Copy link
Contributor Author

tgolen commented Oct 12, 2021

Heh, yeah... I think most of our forms will have this problem.

Copy link
Contributor

@aldo-expensify aldo-expensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, tested on web and works for me!

@aldo-expensify aldo-expensify merged commit d66c278 into main Oct 12, 2021
@aldo-expensify aldo-expensify deleted the tgolen-offline-links branch October 12, 2021 18:57
github-actions bot pushed a commit that referenced this pull request Oct 12, 2021
Show growl when clicking on links in offline mode

(cherry picked from commit d66c278)
tgolen added a commit that referenced this pull request Oct 12, 2021
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @aldo-expensify in version: 1.1.7-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @aldo-expensify in version: 1.1.7-25 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants