Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace pages copy changes and growl on save #5759

Merged
merged 7 commits into from
Oct 12, 2021

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Oct 11, 2021

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/180784
$ https://github.com/Expensify/Expensify/issues/180786
$ https://github.com/Expensify/Expensify/issues/180789
$ https://github.com/Expensify/Expensify/issues/180793
$ https://github.com/Expensify/Expensify/issues/180800
$ https://github.com/Expensify/Expensify/issues/180802
$ https://github.com/Expensify/Expensify/issues/180804

Tests / QA Steps

  1. Create a new workspace if you don't already have one
  2. Go to Settings -> Your workspace
  3. Verify that you see General settings and a menu item.
  4. Click on General settings
  5. Verify that the title on the settings page is General settings, not Edit workspace
  6. Verify that the Default currency drop-down has a lowercase C in currency
  7. Change the default currency, then hit save.
  8. Verify that a Growl message appears which says Your workspace settings were successfully chagned!
  9. Go to Settings -> Your workspace -> Reimburse receipts
  10. Verify that there is a section title reading Unlock next-day reimbursements instead of Unlock next day reimbursements
  11. Go to Settings -> Your workspace -> Send invoices
  12. Verify that there is a button reading Send invoice, rather than Send invoices
  13. Verify that the section title says Unlock online invoice collection, rather than Unlock online invoices collection.
  14. Click on Settings -> Your workspace -> Manage members and verify that the page title says Manage members, not Members.
  15. Go to Settings -> Preferences and change your preferred language to Español.
  16. Go to Configuración -> Your workspace -> Configuración general
  17. Verify that the title on the page is Configuración general
  18. Change the default currency, then hit save.
  19. Verify that a Growl message appears which says ¡Tus configuraciónes del espacio de trabajo se han guardado correctamente!.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Testing step(s) Screenshot
5-6
8
10
12-13
14
17
19

Mobile Web

Desktop

iOS

Android

@roryabraham roryabraham self-assigned this Oct 11, 2021
@roryabraham roryabraham changed the title Change workspace page titles and add a growl on save Workspace pages copy changes and growl on save Oct 11, 2021
@roryabraham
Copy link
Contributor Author

Just need confirmation on one translation, requested here.

@roryabraham roryabraham marked this pull request as ready for review October 11, 2021 20:53
@roryabraham roryabraham requested a review from a team as a code owner October 11, 2021 20:53
@MelvinBot MelvinBot requested review from nickmurray47 and removed request for a team October 11, 2021 20:53
nickmurray47
nickmurray47 previously approved these changes Oct 11, 2021
Copy link
Contributor

@nickmurray47 nickmurray47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and tests well - feel free to self-merge once that translation is confirmed

@roryabraham
Copy link
Contributor Author

@nickmurray47 need another approval b/c I had to adjust the Spanish copy.

@roryabraham roryabraham merged commit 8fd5aec into main Oct 12, 2021
@roryabraham roryabraham deleted the Rory-TitlesWorkspaceSettings branch October 12, 2021 16:36
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions bot pushed a commit that referenced this pull request Oct 14, 2021
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @AndrewGable in version: 1.1.7-21 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@kevinksullivan
Copy link
Contributor

QA looks good! Only discrepancy I saw was in:

  1. Verify that a Growl message appears which says Your workspace settings were successfully changed!

You'll notice it says "saved', which I actually think is better than what the test copy is looking for (since Save is the button copy and it's always active even when not changing currency), so I think we keep it as is.

image

Aside from that, we are dealing with the "spanish curse", so I can't validate those copy changes. checking off deploy.

@roryabraham
Copy link
Contributor Author

roryabraham commented Oct 15, 2021

I QA'd the Spanish side of this issue and it was a pass! I'm stuck in Spanish locale so couldn't QA everything. But I think we are good to check this off.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.1.7-25 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants