Tiny improvement on the getShouldShowAlertPrompt method #5738
Conversation
| @@ -107,7 +107,7 @@ class WorkspaceInvitePage extends React.Component { | |||
| * @returns {Boolean} | |||
| */ | |||
| getShouldShowAlertPrompt() { | |||
| return _.size(lodashGet(this.props.policy, 'errors', {})) > 0 || lodashGet(this.props.policy, 'alertMessage.length') > 0; | |||
| return _.size(lodashGet(this.props.policy, 'errors', {})) > 0 || lodashGet(this.props.policy, 'alertMessage').length > 0; | |||
There was a problem hiding this comment.
I think this will actually cause the same problem as before 😅. If alertMessage isn't there it'll be calling length on undefined. I think we need just a default value to be the third parameter of the lodashGet function.
There was a problem hiding this comment.
Ha, I was just testing this and thought "wait a minute....." 🤦
There was a problem hiding this comment.
Gimme one sec. Running this with a new account. Missed this comment #5727 (comment)
There was a problem hiding this comment.
Just ran this with a new account and it looks like alertMessage will be set as an empty string. I think I'll just default it to an empty string just in case?
Luke9389
changed the title
Luke9389
changed the title
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @TomatoToaster in version: 1.1.7-25 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀
|
Details
Implementing a tiny improvement that @marcaaron suggested here: #5729 (comment)
Related to
#5729 (comment)
Tests
Same as Web QA done locally
QA Steps
Tested On
Screenshots
Web