Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some additional translations for workspaces #5725

Merged
merged 3 commits into from
Oct 8, 2021
Merged

Some additional translations for workspaces #5725

merged 3 commits into from
Oct 8, 2021

Conversation

Gonals
Copy link
Contributor

@Gonals Gonals commented Oct 8, 2021

@tgolen

Tests

None

QA Steps

None

@Gonals Gonals requested a review from tgolen October 8, 2021 07:47
@Gonals Gonals self-assigned this Oct 8, 2021
@Gonals Gonals requested a review from a team as a code owner October 8, 2021 07:47
@MelvinBot MelvinBot requested review from mountiny and removed request for a team October 8, 2021 07:47
mountiny
mountiny reviewed Oct 8, 2021
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lokos good, just some linting errors. I am not sure how they occured in this PR if you have not changed the CopyTextToClipboard file 😅

@Gonals
Copy link
Contributor Author

Gonals commented Oct 8, 2021

Lokos good, just some linting errors. I am not sure how they occured in this PR if you have not changed the CopyTextToClipboard file 😅

Ah! This is branched-off @tgolen's PR, and it will merge to his branch. Those are basically introduced in this WIP PR

@mountiny
Copy link
Contributor

mountiny commented Oct 8, 2021

@Gonals aaaah, I have not noticed that! Thank you for clarifying!

@mountiny mountiny self-requested a review October 8, 2021 08:14
mountiny
mountiny approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case lgtm! All yours @tgolen.

@tgolen tgolen merged commit d521f9f into tgolen-workspace-settings Oct 8, 2021
@tgolen tgolen deleted the alberto-workspace-translation branch October 8, 2021 15:07
@OSBotify OSBotify mentioned this pull request Oct 15, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @tgolen in version: 1.1.7-25 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgolen tgolen tgolen approved these changes

@mountiny mountiny mountiny approved these changes

Assignees

@Gonals Gonals

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gonals @mountiny @OSBotify @tgolen