Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: negative badge count #5686

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Conversation

kidroca
Copy link
Contributor

@kidroca kidroca commented Oct 6, 2021

Details

Fixed Issues

$ #4425

Tests

  1. Use two accounts side by side to send messages back and forth
  2. Have no unreads
  3. Select a report go to "Report Details" and set you notification preference to "daily"
    • I do that by appending /details to a report route as I don't see any other way atm
  4. From the other account send some messages to report from step 3)
  5. You should see a badge/title count of just (1)

QA Steps

Same as above

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen.Recording.2021-10-06.at.17.03.14.mov
  • left tab shows staging with the (-1) bug, right tab show the issue fixed locally

Mobile Web

Android.Emulator.-.Pixel_2_API_29_5554.2021-10-06.20-17-51.mp4

Desktop

Screen.Recording.2021-10-06.at.17.21.57.mov

iOS

image

Android

image

@kidroca kidroca marked this pull request as ready for review October 6, 2021 17:21
@kidroca kidroca requested a review from a team as a code owner October 6, 2021 17:21
@MelvinBot MelvinBot removed the request for review from a team October 6, 2021 17:21
@botify botify requested a review from iwiznia October 6, 2021 17:21
@iwiznia
Copy link
Contributor

iwiznia commented Oct 12, 2021

Sorry for the delay, I must've missed this notification. Next time feel free to bump me in the PR for review.

@iwiznia iwiznia merged commit 76b90e1 into Expensify:main Oct 12, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@kidroca
Copy link
Contributor Author

kidroca commented Oct 12, 2021

No problem I thought it was due to the n6-hold

BTW sorry for not adding the [Hold] title I opened the PR before this requirement was posted

...

Sorry for the delay, I must've missed this notification. Next time feel free to bump me in the PR for review.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @iwiznia in version: 1.1.7-25 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants