Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update /requestor to /personal-information when redirected #5264

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Sep 15, 2021

Details

This PR updates the personal-information path so users land on the right VBA step when redirected.

Fixed Issues

$ #5263

Tests

  1. Login to an account with a Workspace.
  2. Navigate to /bank-account/requestor.
  3. Verify that the url does not change and you land on the Bank Account step.
  4. Now, navigate to /bank-account/personal-information.
  5. Verify that you land on the Personal Information step.
  6. Refresh the page and verify that you still land on the Personal Information step.

QA Steps

Steps above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

Desktop

iOS

Android

@luacmartins luacmartins self-assigned this Sep 15, 2021
@luacmartins luacmartins requested a review from a team September 15, 2021 15:58
@luacmartins luacmartins marked this pull request as ready for review September 15, 2021 15:58
@MelvinBot MelvinBot requested review from thienlnam and removed request for a team September 15, 2021 15:59
@thienlnam
Copy link
Contributor

When I navigate to /bank-account/requestor, I get redirected to the validate step. Just wanted to make sure this was expected behavior

testflow.mp4

@thienlnam
Copy link
Contributor

Additionally, navigating to /bank-account/personal-information indeed takes me to the Personal Information step but once I refresh I also redirect to the /validate step

@luacmartins
Copy link
Contributor Author

Hmmm does your test account have a bank account awaiting validation? You can check by going to OldDot Settings > Account > Payment. That would explain the behavior seen here.

Screen Shot 2021-09-15 at 11 15 45 AM

@thienlnam
Copy link
Contributor

thienlnam commented Sep 15, 2021

Yup, the account is waiting for validation as I was testing it for a VBA setup flow. As long as these are expected this is good to go

@thienlnam thienlnam merged commit 79ba0f2 into main Sep 15, 2021
@thienlnam thienlnam deleted the cmartins-fix-requestor-url branch September 15, 2021 17:38
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @thienlnam in version: 1.0.98-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.0.99-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants