Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add internationalization beta #5256

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Sep 14, 2021

Details

In #4967 we removed the internationalization beta, but according to #4967 (comment) we do not yet want to remove it. This PR re-adds the beta (files had changed so GH revert functionality didn't work).

Fixed Issues

Comment: #4967 (comment)

Tests

  1. Update this line to remove the isDevelopment() check.
  2. Sign out of the app, on the sign-in page confirm you don't see the option to change from English to Spanish.
  3. Sign into an account that is on the beta, confirm you can see the English/Spanish dropdown

QA Steps

  1. Sign out of the app, on the sign-in page confirm you don't see the option to change from English to Spanish
  2. Sign into an account that is on the beta, then go to Preferences, confirm you can change from English to Spanish

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@Jag96 Jag96 requested a review from a team as a code owner September 14, 2021 21:09
@Jag96 Jag96 self-assigned this Sep 14, 2021
@MelvinBot MelvinBot requested review from robertjchen and removed request for a team September 14, 2021 21:09
@roryabraham roryabraham merged commit 86bec1b into main Sep 15, 2021
@roryabraham roryabraham deleted the joe-re-add-internationalization-beta branch September 15, 2021 17:58
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.0.98-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.0.99-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants