Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new job to leave comment to new contributor #5229

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

aldo-expensify
Copy link
Contributor

@aldo-expensify aldo-expensify commented Sep 13, 2021

Hey @roryabraham , I added you as a reviewer as I think you know very well how this is supposed to be implemented :)

I didn't spot any problem with the code provided in the GH issue besides changing çount for count

Details

Add new job "newContributorReminder" to preDeploy.yml. Steps in this job:

  1. Checkout repository
  2. Find last merged PR to get author
  3. Get count of PR's done by this author
  4. If count of PR's is exactly 1, leave a comment in the merged PR reminding the contributor about things to expect/responsibilities.

I have these doubts about this:

  1. I would add the internal QA label, is that correct in this case?
  2. In the first step, should we keep fetch-depth: 0 for the uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f? I left it there because removing it would only make sense to me for performance reasons, but I guess that's not too important here. Fetching with a narrower scope could make it miss somethings we need to find? The PR's?
  3. What happen if two different first contributors' PRs are merged about the same time. Would this job be able to run between each of these PRs? or probably one of them would miss it. I'm guessing that this would be a very rare case, and if one contributor misses his comment, it's not a big deal, but anyway I'm curious about that case :)

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/176233

Tests

  • Create a PR and merge it with an account that has not done any PR before
  • The PR should get the new comment
  • Do a PR again with the same account and merge it
  • The new PR shouldn't get the new comment

QA Steps

Reach out to @aldo-expensify to perform QA of this issue

@aldo-expensify aldo-expensify self-assigned this Sep 13, 2021
@aldo-expensify aldo-expensify requested a review from a team as a code owner September 13, 2021 19:20
@MelvinBot MelvinBot requested review from nickmurray47 and removed request for a team September 13, 2021 19:20
@roryabraham
Copy link
Contributor

I would add the internal QA label, is that correct in this case?

We don't yet have an internal QA checklist for New Expensify. You'll just have to remember to QA this in the next deploy cycle by submitting a PR with a new GitHub account (or just verifying that it works for the next first-time contributor PR merged).

@roryabraham
Copy link
Contributor

In the first step, should we keep fetch-depth: 0

I think it's safe to remove in this case, so we should.

@roryabraham
Copy link
Contributor

What happen if two different first contributors' PRs are merged about the same time.

Two separate jobs would happen in different GHA runners at the same time. Should still work fine.

.github/workflows/preDeploy.yml Outdated Show resolved Hide resolved
.github/workflows/preDeploy.yml Show resolved Hide resolved
.github/workflows/preDeploy.yml Outdated Show resolved Hide resolved
@aldo-expensify
Copy link
Contributor Author

I would add the internal QA label, is that correct in this case?

We don't yet have an internal QA checklist for New Expensify. You'll just have to remember to QA this in the next deploy cycle by submitting a PR with a new GitHub account (or just verifying that it works for the next first-time contributor PR merged).

Sounds good. [NO QA] should stay there, right? because this won't be done by applause

@aldo-expensify
Copy link
Contributor Author

Update: addressed comments!

@roryabraham
Copy link
Contributor

Sounds good. [NO QA] should stay there, right? because this won't be done by applause

Yep, or you can utilize applause and make the QA steps "reach out to @aldo-expensify to perform QA of this issue".

Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aldo-expensify aldo-expensify changed the title [NO QA] Add new job to leave comment to new contributor Add new job to leave comment to new contributor Sep 14, 2021
@nickmurray47 nickmurray47 merged commit e012bc8 into main Sep 14, 2021
@nickmurray47 nickmurray47 deleted the aldo_new-contributor-reminder branch September 14, 2021 11:38
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham
Copy link
Contributor

Looks like this worked 🎉 #5060 (comment)

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @nickmurray47 in version: 1.0.98-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@mvtglobally
Copy link

@aldo-expensify, PR has been deployed. Let us know if you want us to perform any QA steps

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.0.99-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@aldo-expensify
Copy link
Contributor Author

@aldo-expensify, PR has been deployed. Let us know if you want us to perform any QA steps

Sorry, I missed this message.

No need @mvtglobally , thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants