-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new job to leave comment to new contributor #5229
Conversation
We don't yet have an internal QA checklist for New Expensify. You'll just have to remember to QA this in the next deploy cycle by submitting a PR with a new GitHub account (or just verifying that it works for the next first-time contributor PR merged). |
I think it's safe to remove in this case, so we should. |
Two separate jobs would happen in different GHA runners at the same time. Should still work fine. |
Sounds good. [NO QA] should stay there, right? because this won't be done by applause |
Update: addressed comments! |
Yep, or you can utilize applause and make the QA steps "reach out to @aldo-expensify to perform QA of this issue". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Looks like this worked 🎉 #5060 (comment) |
🚀 Deployed to staging by @nickmurray47 in version: 1.0.98-2 🚀
|
@aldo-expensify, PR has been deployed. Let us know if you want us to perform any QA steps |
Sorry, I missed this message. No need @mvtglobally , thanks! |
Hey @roryabraham , I added you as a reviewer as I think you know very well how this is supposed to be implemented :)
I didn't spot any problem with the code provided in the GH issue besides changing
çount
forcount
Details
Add new job "newContributorReminder" to
preDeploy.yml
. Steps in this job:I have these doubts about this:
internal QA
label, is that correct in this case?fetch-depth: 0
for theuses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
? I left it there because removing it would only make sense to me for performance reasons, but I guess that's not too important here. Fetching with a narrower scope could make it miss somethings we need to find? The PR's?Fixed Issues
$ https://github.com/Expensify/Expensify/issues/176233
Tests
QA Steps
Reach out to @aldo-expensify to perform QA of this issue