Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed placeholder to label for Bank Account Step #5198

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

akshayasalvi
Copy link
Contributor

@Jag96 Can you please review?

Details

  • Changed placeholder prop to label prop for Text fields in BankAccountStep

Fixed Issues

$ #5026

Tests

  1. Entered data into the fields and verified that labels show

QA Steps

  1. Navigate to /bank-account/
  2. Click on Connect manually
  3. Enter values in Routing Number and Account Number
  4. Ensure that the labels show up.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web-labels

Mobile Web

mweb-labels

Desktop

desktop-labels

iOS

ios-labels

Android

android-labels

@akshayasalvi akshayasalvi requested a review from a team as a code owner September 10, 2021 17:38
@MelvinBot MelvinBot requested review from marcaaron and removed request for a team September 10, 2021 17:39
@Jag96 Jag96 merged commit 02ae8b0 into Expensify:main Sep 10, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.0.96-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 13, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-20. 🎊

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.97-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants