Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy changed to Start a Call #5187

Merged

Conversation

Santhosh-Sellavel
Copy link
Collaborator

Details

Just a copy change from "Video chat" to "Start a Call".

Fixed Issues

$ #4941

Tests & QA Steps

  1. Open any user chat on the web or Desktop, hover over the 📞 icon.
  2. Tooltip should show Start a Callor Iniciar una llamada based on language preferences.

Tested On

  • Web
  • Desktop

Screenshots

Web

Screenshot 2021-09-10 at 9 58 19 AM

Screenshot 2021-09-10 at 9 57 54 AM

Desktop

Screenshot 2021-09-10 at 10 06 01 AM

Screenshot 2021-09-10 at 10 06 27 AM

@Santhosh-Sellavel Santhosh-Sellavel requested a review from a team as a code owner September 10, 2021 04:40
@MelvinBot MelvinBot requested review from chiragsalian and removed request for a team September 10, 2021 04:40
Copy link
Contributor

@chiragsalian chiragsalian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chiragsalian chiragsalian merged commit 894e683 into Expensify:main Sep 10, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @chiragsalian in version: 1.0.96-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 13, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-20. 🎊

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.97-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants