Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updated button sizes to small for Edit Comment #5170

Merged
merged 1 commit into from
Sep 10, 2021
Merged

fix: Updated button sizes to small for Edit Comment #5170

merged 1 commit into from
Sep 10, 2021

Conversation

mananjadhav
Copy link
Collaborator

@AndrewGable Quick review on this one?

Details

  • Added small property to buttons

Fixed Issues

$ #4896

Tests

  1. Tested the button sizes on all platforms
  2. Tested multiple edits together

QA Steps

  1. Go to any Chat
  2. Right-click on any sent messages and click on Edit
  3. Button sizes should be smaller

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web-button-size

Mobile Web

mweb-button-size

Desktop

desktop-button-size

iOS

ios-button-size

Android

android-button-size

@mananjadhav mananjadhav requested a review from a team as a code owner September 9, 2021 19:28
@MelvinBot MelvinBot requested review from marcaaron and removed request for a team September 9, 2021 19:28
@AndrewGable AndrewGable merged commit 01f351c into Expensify:main Sep 10, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Sep 10, 2021
Closed
10 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @AndrewGable in version: 1.0.96-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 13, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-20. 🎊

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.97-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewGable AndrewGable AndrewGable approved these changes

@marcaaron marcaaron Awaiting requested review from marcaaron

Assignees

@mananjadhav mananjadhav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mananjadhav @OSBotify @botify @AndrewGable