Show No access Modal when Copilot tries to add new contact method on behalf of owner. #50643
+75
−59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show No access Modal when Copilot tries to add new contact method on behalf of owner.
Details
As per App's philosophy we do not allow certain actions to be performed by a copilot on behalf of owner add new contact method is one of them.
When copilot completes add new contact method flow on behalf of owner - BE return an error, this PR implements FE handling for the same by not allowing copilot to start the flow and provide explanation in form of a Modal.
Fixed Issues
$ #50063
PROPOSAL: #50063 (comment)
Tests
Same QA test
Offline tests
Same ad QA test.
QA Steps
Prerequisites: Enable Copilot Beta, and perform following steps as a copilot. To add account as copilot see link.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-10-11.at.5.46.46.PM.mov
Android: mWeb Chrome
Screen.Recording.2024-10-11.at.5.48.19.PM.mov
iOS: Native
Screen.Recording.2024-10-11.at.6.33.07.PM.mov
iOS: mWeb Safari
Screen.Recording.2024-10-11.at.6.41.00.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2024-10-11.at.5.45.14.PM.mov
MacOS: Desktop
Screen.Recording.2024-10-11.at.6.09.30.PM.mov