-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [Debug Mode] Show reason for RBR/GBR on LHN tabs #49962
base: main
Are you sure you want to change the base?
[WIP] [Debug Mode] Show reason for RBR/GBR on LHN tabs #49962
Conversation
I need to add unit tests for the new hook that I created - Besides this, I also have to:
|
…rbr-gbr-on-lhn-tabs # Conflicts: # src/languages/en.ts
Today's update:
To continue tomorrow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review
src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/DebugTabView.tsx
Outdated
Show resolved
Hide resolved
…rbr-gbr-on-lhn-tabs # Conflicts: # src/CONST.ts # src/languages/en.ts # src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx
Today's update:
To continue tomorrow:
|
…rbr-gbr-on-lhn-tabs
Today's update:
Todo:
|
src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/DebugTabView.tsx
Outdated
Show resolved
Hide resolved
src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/DebugTabView.tsx
Outdated
Show resolved
Hide resolved
I forgot to leave my update yesterday, here it is:
Todo:
|
Details
Fixed Issues
$#49600
PROPOSAL: N/A
Tests
Offline tests
QA Steps
To trigger a GBR in Inbox
Make sure there are no reports with RBR
Inbox
page+
on the chat editor and selectAssign Task
View
button after the messageTo trigger a RBR in Inbox
Category
)View
, you should be redirected to the expense reportTo trigger a RBR in Settings
Profile
, then openContact method
View
, you should be redirected to the contact method pagePR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android.-.Native.mp4
Android: mWeb Chrome
Android.-.Chrome.mp4
iOS: Native
iOS.-.Native.mp4
iOS: mWeb Safari
iOS.-.Safari.mp4
MacOS: Chrome / Safari
MacOS.-.Chrome.mp4
MacOS: Desktop
MacOS.-.Native.mp4