Update CONTRIBUTING.md #4996
Update CONTRIBUTING.md #4996
Conversation
LOTS of updates, almost exclusively in "Finding Jobs", I'm going to post in #contributor-management to get bonus eyes on it in case anything isn't _perfect_
There was a problem hiding this comment.
Love the changes! Added some comments that could potentially make a few pieces clearer, let me know what you think @mallenexpensify 👍
|
Appreciate the 👀 @Beamanator , I wasn't sure what actions I was supposed to make to approve them so I added a bunch of 👍. |
Reworded the "Note: If your solution is also merged, we will give you a $250 bonus for fixing the bug/enhancement." sentence for clarity
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
Sorry, I'm not very knowledgeable about pull requests. I don't quite understand how to satisfy this.
I have read the CLA Document and I hereby sign the CLA |
|
@Christinadobrzyn no worries! I think you need to make that comment about signing the CLA it's own separate comment though. Once you've done that, to re-run the checks you go click on Then click on |
|
Yeah @Christinadobrzyn in case it wasn't super clear, first just add a comment with this exact text: |
|
I have read the CLA Document and I hereby sign the CLA |
|
Amazing!! Thanks so much Nikki and Alex! Sorry for being a little slow with this kinda stuff. Done! |
|
Looks great! Once @mallenexpensify commits the requested changes I think we'll be good to go 👍 |
Co-authored-by: Alex Beaman <alexbeaman@expensify.com>
Co-authored-by: Alex Beaman <alexbeaman@expensify.com>
Co-authored-by: Alex Beaman <alexbeaman@expensify.com>
Co-authored-by: Alex Beaman <alexbeaman@expensify.com>
|
K, I think I committed all the suggested changes |
|
@mallenexpensify think this comment is also useful to add, or did you want to just scratch that one? :D |
|
I can't seem to be able to commit it, can you @Beamanator ? |
|
@mallenexpensify Good call, seems another commit changed that text so my original suggestion couldn't overwrite! I made a new suggestion here and committed it, so we should be good to merge once the tests pass 👍 |
|
Manually cancelled & restarted workflow jobs since the E2E IOS Tests were taking > 3.5 hours (see "run tests" here: https://github.com/Expensify/App/pull/4996/checks?check_run_id=3565873759) |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @Beamanator in version: 1.0.96-1 🚀
|
|
🚀 Deployed to production by @francoisl in version: 1.0.97-0 🚀
|
LOTS of updates, almost exclusively in "Finding Jobs", I'm going to post in #contributor-management to get bonus eyes on it in case anything isn't perfect
Details
Fixed Issues
$ GH_LINK
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android