show specific err msg on password form #4945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puneetlath
reviewed
Sep 1, 2021
There was a problem hiding this comment.
A couple minor comments. Up to you whether you agree or not.
Also, just waiting for a response on this: #4856 (comment)
|
Making the required changes! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
54 tasks
|
🚀 Deployed to staging by @puneetlath in version: 1.0.92-1 🚀
|
|
This has been deployed to production and is now subject to a 7-day regression period. |
|
🚀 Deployed to production by @roryabraham in version: 1.0.93-1 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Proposal: #4856 (comment)
Approval : #4856 (comment)
As discussed, I've added conditions for 3 specific error messages on password form.
Fixed Issues
$ #4856
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android