Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace #49202

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+2 −1
Open

LHN - RBR appears on the wrong workspace chat for an error occurring on another workspace #49202

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
061efbf
Issue resolved: LHN - RBR appears on the wrong workspace chat for an …
SIMalik Sep 14, 2024
044f575
Tiny lint issue resolved
SIMalik Sep 23, 2024
fc04b59
Resolved merge conflicts
SIMalik Oct 8, 2024
38c5431
Fix test - returns report action that contains errors
SIMalik Oct 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/OptionsListUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ function uniqFast(items: string[]): string[] {
function getAllReportErrors(report: OnyxEntry<Report>, reportActions: OnyxEntry<ReportActions>): OnyxCommon.Errors {
const reportErrors = report?.errors ?? {};
const reportErrorFields = report?.errorFields ?? {};
const reportActionsArray = Object.values(reportActions ?? {});
const reportActionsArray = Object.values(reportActions ?? {}).filter(action => !ReportActionUtils.isDeletedAction(action));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const reportActionsArray = Object.values(reportActions ?? {}).filter(action => !ReportActionUtils.isDeletedAction(action));
const reportActionsArray = Object.values(reportActions ?? {}).filter((action) => !ReportActionUtils.isDeletedAction(action));

tiny lint issue. :)

Copy link
Contributor

@ntdiary ntdiary Sep 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SIMalik, can you please fix this tiny issue? I will fill the check list soon. :)

const reportActionErrors: OnyxCommon.ErrorFields = {};

for (const action of reportActionsArray) {
Expand Down
Loading