Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: validate new contact method action #48320
feat: validate new contact method action #48320
Changes from 11 commits
087f2fd
74ec327
650f47f
c11acac
8d8f6a4
e9b4406
0714b23
db17bf3
0a40dd5
41ef7e8
c2f3b6f
0a2c0b2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@getusha What is the purpose for this logic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@parasharrajat We started requiring verification before adding a contact method. the new flow is
temporarily save new contact > verify action > add the new contact method.
saveNewContactMethodAndRequestValidationCode
just saves the contact method temporarily and requests a magic code, so this logic just navigates youValidateContactActionPage
after the magic code is sentApp/src/libs/actions/User.ts
Line 342 in e1d726e