-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show GBR if manager w/out parent access on procesing report #48226
Conversation
@Pujan92 can you please prioritize this one today? 🙇♂️ |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2024-08-30.at.00.38.16.mp4MacOS: Desktop |
@Beamanator I get an error while approving from Approver 1. Screen.Recording.2024-08-30.at.00.38.16.mp4 |
Oh shit @Pujan92 that's actually expected until https://github.com/Expensify/Auth/pull/12211 gets to prod 🙃 |
I updated the test steps, @Pujan92 can you please test again without clicking Approve (step 9)? |
Yes, that approve button shows in the report header. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.0.27-0 🚀
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.27-1 🚀
|
cc @marcochavezf in case you can help review 🙏
Details
If a report's approver gets removed from a submitter's approval chain, the approver won't have access to the workspace chat, but they'll still need to approve old linked expense reports where they were the approver.
In this case, we want to show GBR to the expense report for that approver, since they won't have access through the workspace chat anymore.
I'm also working on an Auth PR to fix this in
GetChats
and to live update the GBR statusFixed Issues
$ https://github.com/Expensify/Expensify/issues/422963
Tests
submitsTo
is set to Approver 1. Approver 1 and Approver 2 should NOT have aforwardsTo
set.submitsTo
to Approver 2Approve
button in the report headerClickApprover
, make sure it works w/out errorsNote: You may not be able to pay yet, that's fineOffline tests
Same
QA Steps
Same
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop