-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO QA]: Feed Added Empty State #48000
[NO QA]: Feed Added Empty State #48000
Conversation
Let's wait for this PR to get merged, so we can reuse the illustration styles from it. |
Yeah no problem - just updated illustration naming and style to avoid merge conflicts |
@narefyev91 We need to merge main to resolve conflicts and reuse the illustration and styles |
# Conflicts: # assets/images/companyCards/emptystate__card-pos.svg # src/components/Icon/Illustrations.ts # src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx
Updated! |
Reviewer Checklist
Screenshots/VideosMacOS: Desktop |
src/pages/workspace/companyCards/WorkspaceCompanyCardsFeedAddedEmptyPage.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Looking good to me. Not a blocker, but we might want @jamesdeanexpensify to take a quick look and suggest some different copy so we can potentially avoid the hanging orphan here: |
Tagging @robertjchen in case @iwiznia is OOO |
Where do you assign your first card from this page? I wonder if that copy could be a bit more instructional, if possible. |
That checks out to me. |
Maybe we just remove "to a member" at the end? I just want to keep the body slightly longer than the header, for balance. Can we see how that looks? |
Looks good to me if it looks good to you! |
I like that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks! 👍
Woooo, TY! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/robertjchen in version: 9.0.27-0 🚀
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.27-1 🚀
|
Details
UI for Feed added empty state
Fixed Issues
$ #47376
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop