Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Fix regression on web due to #4760 #4800

Merged
merged 2 commits into from
Aug 24, 2021
Merged

[No QA] Fix regression on web due to #4760 #4800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
136f34a
Update CAPTURE_METRICS check in babel.config.js
kidroca Aug 24, 2021
c2d1d8e
Add `react-native-flipper` to `includeModules`
kidroca Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const metro = {
* By default <React.Profiler> is disabled in production as it adds small overhead
* When CAPTURE_METRICS is set we're explicitly saying that we want to capture metrics
* To enable the <Profiler> for release builds we add these aliases */
if (process.env.CAPTURE_METRICS) {
if (process.env.CAPTURE_METRICS === 'true') {
Copy link
Contributor Author

@kidroca kidroca Aug 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

process.env values are string so we need to check explicitly for "true"
That's how other compile check are made as well (e.g. process.env.ANALYZE_BUNDLE === 'true')

const path = require('path');
const profilingRenderer = path.resolve(
__dirname,
Expand Down
1 change: 1 addition & 0 deletions config/webpack/webpack.common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ const includeModules = [
'react-native-modal',
'react-native-onyx',
'react-native-gesture-handler',
'react-native-flipper',
].join('|');

const webpackConfig = {
Expand Down