Chat - File does not appear with strikethrough style when uploaded offline and deleted

[Krishna2323]

Details

Fixed Issues

$ #46616
PROPOSAL: #46616 (comment)

Tests

1. Go to any chat
2. Upload a file (format: .txt/.html/.zip/)
3. Upload image & video
4. Go offline
5. Right click on the file
6. Click Delete comment
7. Verify an overlay with trash icon is shown for deleted video & image and the filename is crossed for the other file. (format: .txt/.html/.zip/)
8. Stay offline and repeat step 2 to 7

• Verify that no errors appear in the JS console

Offline tests

1. Go to any chat
2. Upload a file (format: .txt/.html/.zip/)
3. Upload image & video
4. Go offline
5. Right click on the file
6. Click Delete comment
7. Verify an overlay with trash icon is shown for deleted video & image and the filename is crossed for the other file. (format: .txt/.html/.zip/)
8. Stay offline and repeat step 2 to 7

QA Steps

1. Go to any chat
2. Upload a file (format: .txt/.html/.zip/)
3. Upload image & video
4. Go offline
5. Right click on the file
6. Click Delete comment
7. Verify an overlay with trash icon is shown for deleted video & image and the filename is crossed for the other file. (format: .txt/.html/.zip/)
8. Stay offline and repeat step 2 to 7

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Monosnap.screencast.2024-09-04.13-32-54.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.1.mp4

MacOS: Desktop

desktop_app.mp4

[melvin-bot]

@dubielzyk-expensify @mananjadhav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[dubielzyk-expensify]

Let me know when there's something visual to check out :)

[Krishna2323]

The code changes are done, I will test last time today and upload the screenshots.

[Krishna2323]

@dubielzyk-expensify, please check the recording and let me know if we want some changes.

Monosnap.screencast.2024-08-28.05-29-20.mp4

[dubielzyk-expensify]

There seems to be something weird happening when you go into offline mode and it immediately showing this before you've even deleted anything:

The trash icon should only appear when something is deleted in offline mode. Which is does when you do your "Delete comment" action, but before that it shows a double or something?

Otherwise the rest of the recording looks good. cc @Expensify/design

[shawnborton]

Yup, I'm also curious about what Jon is mentioning.

[dannymcclain]

Same. Other than that weirdness Jon pointed out I think it's looking good.

[Krishna2323]

Thanks for the review, I think that was already deleted action which might have failed that's why it was shown but I will double check that.

[Krishna2323]

@Expensify/design, I apologize for forgetting to show the visuals in light mode 😅. Could you please confirm if the video looks correct in both modes?

Monosnap.screencast.2024-08-29.06-23-50.mp4

[dubielzyk-expensify]

Thanks for providing video for light mode 😄

Is the icon using the icon color variable? Cause it looks to be the same icon color as in dark mode which is a darker than we want. In light mode it should appear a bit lighter. But it could be the recording screwing up with me here.

[shawnborton]

I think the video might be correct? I think the color for icons is darker in light mode, and lighter in dark mode.

[dannymcclain]

Haha, I'm with both of you—the icon color in light mode doesn't quite look right to me 🤨

Here's a Figma screenshot. The icon is just using our standard icons color variable.

[Krishna2323]

Thanks, I will update and provide the result shortly.

[Krishna2323]

@Expensify/design, does this look correct? The color code has been updated to the icon variable, but it will appear lighter than in this design because the report comment has an opacity of .5 when deleted offline. I find it very difficult to maintain the original icon color with the reduced opacity. The only viable solution I can think of is to update the color to a brighter version of the icon variable so that it appears closer to the original even with the reduced opacity.

deleted_indicator_updated_color.mp4

[dannymcclain]

Yeah I definitely want to just use the variables as they are.

I would've assumed we applied the opacity only on the image and not the whole container including the icon.

Yeah I agree, though I think the whole entire post gets reduced opacity (even the name/avatar/timestamp) so I think if we're using the right variables I'm fine with how this is looking.

[dubielzyk-expensify]

so I think if we're using the right variables I'm fine with how this is looking.

SGTM. Let's push ahead unless @shawnborton thinks otherwise

[shawnborton]

Yup same, all good with me!

[Krishna2323]

Thanks everyone, will update the recordings for all platforms soon, then this will be ready for C+ review.

[Krishna2323]

@mananjadhav, I have updated the test steps and added the videos for all platforms except for android native. There is a android specific bug I'm trying to solve. The trash icon opacity is also reduced.

Let me know if you have an idea about this issue. Thanks

Monosnap.screencast.2024-09-04.13-32-54.mp4

[Krishna2323]

@mananjadhav, can you please take a look at the comment above?

[mananjadhav]

I'll be able to take a look at this tomorrow.

[Krishna2323]

@mananjadhav, can you please have a look? I think we are super close to merging this, the implementation works well on all platforms except android native :(

[mananjadhav]

I couldn't find the solution for the Android bug. I am still working on this.

[Krishna2323]

@mananjadhav, I think we should open a new issue for the opacity bug, as I believe it's out of the scope of this PR. We should try to close this one as soon as possible since it's been open for almost a month.

But I will try again to fix the opacity bug today or tomorrow.

[mananjadhav]

yeah let's do that. @neil-marcellini does that work? @Krishna2323 can you please merge conflicts?

[Krishna2323]

merged main, I'm not sure about the ESlint check, I think that's not from this PR.

[mananjadhav]

@Krishna2323 I think we'll need to fix the eslint issues even if they're unrelated to the PR. It is because we're touching those files and the new lint rules are failing.

@neil-marcellini can you please confirm?

[mananjadhav]

Left a few comments.

[mananjadhav]

Still going through these styles.

[neil-marcellini]

@Krishna2323 I think we'll need to fix the eslint issues even if they're unrelated to the PR. It is because we're touching those files and the new lint rules are failing.

@neil-marcellini can you please confirm?

Hi, thanks for asking. The latest I've heard is that if the ES Lint checks are related to files touched in the current PR, then we require them to be fixed before the issue can be considered complete and paid. If the fixes are small then we like to see the changes in the current PR. Otherwise, like in this case where we need to migrate to useOnyx, we should handle it in a separate PR. You could also search to see if there is already an issue to migrate to useOnyx for these files.

[Krishna2323]

@mananjadhav, I have fixed other files but I'm no sure what to do with ImageRenderer file since the onyx value is used in the memo.

App/src/components/HTMLEngineProvider/HTMLRenderers/ImageRenderer.tsx

Lines 117 to 126 in 7dde09e

	export default withOnyx<ImageRendererProps, ImageRendererWithOnyxProps>({
	user: {
	key: ONYXKEYS.USER,
	},
	})(
	memo(
	ImageRenderer,
	(prevProps, nextProps) => prevProps.tnode.attributes === nextProps.tnode.attributes && prevProps.user?.shouldUseStagingServer === nextProps.user?.shouldUseStagingServer,
	),
	);

[Krishna2323]

@mananjadhav, friendly bump on the comment above ^

[Krishna2323]

@mananjadhav, any updates?

[mananjadhav]

I couldn't check this over the weekend, but I'll try to check today. I think it's best to post on open-source channel to get more eyes.

[Krishna2323]

@mananjadhav, we no longer need to make this change, I guess it has been done somewhere else. You can continue with the checklist.