-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/47308 workspace feed fixes #47844
Fix/47308 workspace feed fixes #47844
Conversation
…rds assigned to the member in details
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-08-26.at.8.02.36.PM.movMacOS: Chrome / SafariScreen.Recording.2024-08-26.at.7.37.33.PM.movMacOS: DesktopScreen.Recording.2024-08-26.at.7.51.17.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM and tests well, github limits 100 mb for video, so i wasn't able to upload complete testing video but parts of it
that said, we're good for merge 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, quite clear changes
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.25-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.25-0 🚀
|
This PR is failing because of issue #48199 |
Details
Fixed Issues
$ #47308
$ #46305
PROPOSAL: #47308 (comment)
Tests
PREREQUISITES: workspaceFeed / all betas enabled
IssueNew Card / Finish Setup button
Navigation after issuing the card
You can test on the same account you tested the previous case
**Filtered Cards in Details"
You can test on the same account you tested the previous cases
Navigation issue - #46305
You can test on the same account you tested the previous cases
Offline tests
QA Steps
same as above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-08-22.at.11.32.08.mov
Android: mWeb Chrome
https://github.com/user-attachments/assets/632c4730-6b5a-422d-ac39-416bd22b6fb3
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-08-22.at.11.04.36.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-08-22.at.11.14.09.mp4
MacOS: Chrome / Safari
MacOS: Desktop
Screen.Recording.2024-08-22.at.10.31.58.mp4