-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default transactionThreadReportID to -1 in ReportActionsView #47781
Conversation
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Bump @allroundexperts |
Reviewer Checklist
Screenshots/Videos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works good!
We did not find an internal engineer to review this PR, trying to assign a random engineer to #44226 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
@nkuoch assigning you as you're assigned to the linked issue! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/nkuoch in version: 9.0.26-1 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.26-6 🚀
|
Details
Fixes #44226.
Fixed Issues
$ #44226
PROPOSAL: https://expensify.slack.com/archives/C05LX9D6E07/p1724230416174789?thread_ts=1721348346.978119&cid=C05LX9D6E07
Tests
Expensify.tsx
.Screenshot of the fields that SHOULDN'T appear:
Offline tests
Same.
QA Steps
Same as above, but it's only possible to test on Web and instead of adding code you have to execute
Onyx.set('report_undefined', {reportName: 'Chat Report'});
andOnyx.set('report_undefined', null);
(after finishing testing) in the browser's console.PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop