Delegate access: Add account switcher #47338

rushatgabhane · 2024-08-13T15:03:03Z

Details

Reference figma: https://www.figma.com/design/0hkXDnwqXN8J51MHEWQeLC/Account-Access-(Copilot)?node-id=1-3&t=lFirw8Aa0NwEygPW-0

Fixed Issues

$ #46920
$ #46921
PROPOSAL:

Tests

Profile picture

Go to settings > Profile
Verify that you can view profile photo, edit and upload a new one.

Share code

Go to settings > Profile
Click share
Verify that share code page opens

Account switcher

Enable the beta newDotCopilot
Go to an account that can act as a copilot for multiple accounts. Or you can add them via oldDot by following instructions on help site.
Click the account switcher
Verify that a popover opens
Verify that you can see all accounts you can act as a copilot
Click an account
Verify that you are logged in as that account now
The app might crash after switching accounts. You can refresh to fix it.
Click account switcher again
Click your original account and verify that you can go back to your account

Offline test

Go offline
Switch accounts
Verify that you see a popover saying you can't perform this action right now

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android not building after upgrade

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-08-28.at.04.24.17.mov

Screen.Recording.2024-08-28.at.15.28.36.mov

iOS: mWeb Safari

Screen.Recording.2024-08-28.at.04.47.06.mov

Screen.Recording.2024-08-28.at.15.30.36.mov

MacOS: Chrome / Safari

Screen.Recording.2024-08-22.at.00.16.59.mov

Screen.Recording.2024-08-13.at.21.58.33.mov

MacOS: Desktop

Screen.Recording.2024-08-28.at.04.50.41.mov

rushatgabhane · 2024-08-28T12:25:40Z

Another issue is after some time, all API calls start returning code 407 session has expired. But the user is not signed out.

We have a request middleware that performs Reauthentication.

But the server never sends a new token, and the middleware never signs out the user. So the user will be stuck with app that is loading and will have to manually sign out.

App/src/libs/Middleware/Reauthentication.ts

Line 31 in 1646d07

    
           const Reauthentication: Middleware = (response, request, isFromSequentialQueue) =>

@dangrous @parasharrajat this is a more global issue so I don't want to touch it 😅
We'll need clear reproduction steps, exact root cause and then a discussion on slack on how to handle this.

rushatgabhane · 2024-08-28T12:29:48Z

IOS: BUG: While offline, Alert does not show up on changing accounts

fixed ✅

rushatgabhane · 2024-08-28T12:35:02Z

@parasharrajat all yours!!! I'm confident on merging. Great work on finding all the bugs and reviewing the code

dangrous · 2024-08-28T13:48:49Z

Another issue is after some time, all API calls start returning code 407 session has expired. But the user is not signed out.

We have a request middleware that performs Reauthentication.

But the server never sends a new token, and the middleware never signs out the user. So the user will be stuck with app that is loading and will have to manually sign out.

App/src/libs/Middleware/Reauthentication.ts

Line 31 in 1646d07

const Reauthentication: Middleware = (response, request, isFromSequentialQueue) =>

@dangrous @parasharrajat this is a more global issue so I don't want to touch it 😅 We'll need clear reproduction steps, exact root cause and then a discussion on slack on how to handle this.

For this one - do you think that's a backend issue? Like, do I need to look at how those Reauthenticate requests are processed on the backend? Or, should we see if we can log the user out if they get a 407 response? Either way I agree this can be handled later. (Roughly how long before you start getting those responses?)

rushatgabhane · 2024-08-28T13:50:43Z

Roughly how long before you start getting those responses

definitely more than 30 minutes

do you think that's a backend issue

On frontend, Reauth assumes that after N retries you will get the auth token in at least one of the requests.

But after switching accounts, reauth does not work on delegate account and not even after gou return back to your account.

Reauth is not possible from the backend itself as soon as the user has switched account or retuned back.

This will be mostly a frontend fix / few changes from backend to sign out

What do you think?

dangrous · 2024-08-28T15:26:03Z

hm yeah if it's over 30 mins, let's handle that as polish. My guess is in the majority of cases 30 mins will be enough

parasharrajat · 2024-08-28T17:57:42Z

@rushatgabhane There is another issue. When we switch accounts, some chat names change to Chat Report in LHN. I think it is not in the scope of this PR but noting it here.

29.08.2024_00.07.50_REC.mp4

rushatgabhane · 2024-08-28T18:14:10Z

@parasharrajat can you attach a screenshot whenever you see it again? so we are on same page

parasharrajat · 2024-08-28T18:40:10Z

Screenshots

🔲 iOS / native

29.08.2024_00.05.03_REC.mp4

🔲 iOS / Safari

29.08.2024_00.08.50_REC.mp4

🔲 MacOS / Desktop

28.08.2024_23.28.17_REC.mp4

🔲 MacOS / Chrome

28.08.2024_23.25.19_REC.mp4

🔲 Android / Chrome

29.08.2024_00.10.49_REC.mp4

🔲 Android / native

29.08.2024_00.06.19_REC.mp4

parasharrajat · 2024-08-28T18:40:30Z

@rushatgabhane Updated the same comment #47338 (comment)

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

dangrous

K, let's do it! It looks good to me, and I think we'll have plenty of time to handle additional issues that come up when we're finalizing the other PRs.

Thank you both so much for all the time you've put into this!

OSBotify · 2024-08-28T21:44:12Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.26-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-30T18:32:40Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.26-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jjcoffee · 2024-09-27T08:13:53Z

src/components/AccountSwitcher.tsx

+    const createBaseMenuItem = (personalDetails: PersonalDetails | undefined, error?: TranslationPaths, additionalProps: MenuItemWithLink = {}): MenuItemWithLink => {
+        return {
+            title: personalDetails?.displayName ?? personalDetails?.login,
+            description: personalDetails?.login,


Coming from #48648, we should have used Str.removeSMSDomain to ensure phone numbers are displayed correctly (without the @expensify.sms suffix).

c3024 · 2024-10-08T10:05:25Z

src/components/AccountSwitcherSkeletonView/index.tsx

-    const headlineSize = variables.fontSizeXLarge;
-    const spaceBetweenHeadlineAndLabel = styles.mt1.marginTop + (variables.lineHeightXXLarge - variables.fontSizeXLarge) / 2;
-    const labelSize = variables.fontSizeLabel;
+    const startPositionX = 30;


Using an absolute start position caused a mismatch between skeleton view and the loaded view. More details here. #49548

rushatgabhane added 30 commits August 12, 2024 17:01

add delegate access type

a06431b

add auth token for delegate access

567058b

add connect as delegate action

40c55fb

make delegated access optional

62ee905

rm display name and email

3d31f79

fix padding bottom style

90a0bc9

fix padding bottom style

0a2b2f7

move profile photo to profile page

b9d2586

align left

2a4eaac

cleanup

7e70fa3

move share button to profile page

1a5e6f7

add padding to share btn

a6b9a44

create account switcher component

d3fbf69

adjust styles to be responsive and text overflow

28dd908

add caret up down icon

c93b7c9

add caret up down icon

d0cf30b

show account switcher

6112f60

add min width 0 style

d8d006d

add beta

cebf129

rm unnecessary style

3655383

add popover menu to show delegates

57dfbed

cleanup

190a319

add styling for menu item

110af74

add badge text

890b23e

add lang

d15ffab

add width for account switcher popover

e0aaba5

cleanup

e05b5d9

cleanup

77f255b

cleanup

cc3c722

add menu item type

b298b0b

rushatgabhane requested a review from dangrous August 28, 2024 12:31

parasharrajat approved these changes Aug 28, 2024

View reviewed changes

dangrous approved these changes Aug 28, 2024

View reviewed changes

dangrous merged commit 1c0a923 into Expensify:main Aug 28, 2024
17 checks passed

This was referenced Aug 28, 2024

Investigate workflow job failing on main: typecheck / typecheck #48211

Closed

Investigate workflow job failing on main: confirmPassingBuild #48212

Closed

dangrous mentioned this pull request Aug 28, 2024

Fix missed moved translation #48213

Merged

50 tasks

This was referenced Aug 28, 2024

Deploy Checklist: New Expensify 2024-08-28 #48221

Closed

Investigate workflow job failing on main: typecheck / typecheck #48224

Closed

Investigate workflow job failing on main: confirmPassingBuild #48225

Closed

izarutskaya mentioned this pull request Aug 29, 2024

[payment due 9/6][$250] Avatar - Unable to choose profile avatar from library #48242

Closed

6 tasks

IuliiaHerets mentioned this pull request Aug 29, 2024

Profile - Tapping on "Account name", shows interaction, but no redirection #48253

Closed

6 tasks

arosiclair mentioned this pull request Aug 29, 2024

Account switcher - No spacing between account switcher icon and the status icon #48261

Open

6 tasks

dangrous mentioned this pull request Sep 4, 2024

Fix copilot bugs #48517

Merged

50 tasks

jjcoffee reviewed Sep 27, 2024

View reviewed changes

jjcoffee mentioned this pull request Sep 27, 2024

[HOLD for payment 2024-09-18][$250] Profile - Phone number login is displayed as @expensify.sms #48648

Closed

6 tasks

c3024 reviewed Oct 8, 2024

View reviewed changes

c3024 mentioned this pull request Oct 8, 2024

[HOLD for payment 2024-10-07][$250] Loading skeleton for Settings header is slightly off #49548

Open

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delegate access: Add account switcher #47338

Delegate access: Add account switcher #47338

rushatgabhane commented Aug 13, 2024 •

edited

Loading

rushatgabhane commented Aug 28, 2024 •

edited

Loading

rushatgabhane commented Aug 28, 2024

rushatgabhane commented Aug 28, 2024

dangrous commented Aug 28, 2024

rushatgabhane commented Aug 28, 2024 •

edited

Loading

dangrous commented Aug 28, 2024

parasharrajat commented Aug 28, 2024 •

edited

Loading

rushatgabhane commented Aug 28, 2024

parasharrajat commented Aug 28, 2024 •

edited

Loading

parasharrajat commented Aug 28, 2024

parasharrajat left a comment

dangrous left a comment

OSBotify commented Aug 28, 2024

OSBotify commented Aug 30, 2024

jjcoffee Sep 27, 2024

c3024 Oct 8, 2024

Delegate access: Add account switcher #47338

Delegate access: Add account switcher #47338

Conversation

rushatgabhane commented Aug 13, 2024 • edited Loading

Details

Fixed Issues

Tests

Profile picture

Share code

Account switcher

Offline test

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

rushatgabhane commented Aug 28, 2024 • edited Loading

rushatgabhane commented Aug 28, 2024

rushatgabhane commented Aug 28, 2024

dangrous commented Aug 28, 2024

rushatgabhane commented Aug 28, 2024 • edited Loading

dangrous commented Aug 28, 2024

parasharrajat commented Aug 28, 2024 • edited Loading

rushatgabhane commented Aug 28, 2024

parasharrajat commented Aug 28, 2024 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat commented Aug 28, 2024

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

dangrous left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 28, 2024

OSBotify commented Aug 30, 2024

jjcoffee Sep 27, 2024

Choose a reason for hiding this comment

c3024 Oct 8, 2024

Choose a reason for hiding this comment

rushatgabhane commented Aug 13, 2024 •

edited

Loading

rushatgabhane commented Aug 28, 2024 •

edited

Loading

rushatgabhane commented Aug 28, 2024 •

edited

Loading

parasharrajat commented Aug 28, 2024 •

edited

Loading

parasharrajat commented Aug 28, 2024 •

edited

Loading