-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hold badge still displayed after paying expense #47192
Fix hold badge still displayed after paying expense #47192
Conversation
@bernhardoj seems like we need to wait for the backend fix, I am still able to reproduce this |
Yes, we still need the BE fix for the hold status removed from the other user. cc: @NikkiWines |
@getusha can you review this today please? |
Bump again here, thanks! |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-08-28.at.5.51.21.in.the.afternoon.movAndroid: mWeb ChromeScreen.Recording.2024-08-28.at.5.53.39.in.the.afternoon.moviOS: NativeScreen.Recording.2024-08-28.at.6.06.34.in.the.evening.moviOS: mWeb SafariScreen.Recording.2024-08-28.at.6.09.32.in.the.evening.movMacOS: Chrome / SafariScreen.Recording.2024-08-28.at.5.29.32.in.the.afternoon.movMacOS: DesktopScreen.Recording.2024-08-28.at.6.10.55.in.the.evening.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one very small comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/robertjchen in version: 9.0.27-0 🚀
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.27-1 🚀
|
Details
When we pay expenses, we don't remove the hold status of the expense. This PR fix it.
Fixed Issues
$ #44616
PROPOSAL: #44616 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4