Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix send validate code in Validation Form" #46846

Conversation

marcaaron
Copy link
Contributor

Reverts #45395

@marcaaron marcaaron requested a review from a team as a code owner August 6, 2024 00:41
@marcaaron marcaaron self-assigned this Aug 6, 2024
@melvin-bot melvin-bot bot requested review from grgia and removed request for a team August 6, 2024 00:42
Copy link

melvin-bot bot commented Aug 6, 2024

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Contributor

github-actions bot commented Aug 6, 2024

@thienlnam
Copy link
Contributor

Straight revert, merging

@thienlnam thienlnam merged commit 17c6a3d into main Aug 6, 2024
12 of 14 checks passed
@thienlnam thienlnam deleted the revert-45395-fix/42626/fix-send-validate-code-in-validate-form branch August 6, 2024 01:36
@melvin-bot melvin-bot bot added the Emergency label Aug 6, 2024
Copy link

melvin-bot bot commented Aug 6, 2024

@thienlnam looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Aug 6, 2024
…end-validate-code-in-validate-form

Revert "Fix send validate code in Validation Form"

(cherry picked from commit 17c6a3d)
@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2024

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.0.16-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2024

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.16-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants