-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix get newer actions is called when going back from the expense page or scroll down to bottom #46787
Fix get newer actions is called when going back from the expense page or scroll down to bottom #46787
Conversation
@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeRecord_2024-08-08-01-10-23.mp4Android: mWeb ChromeRecord_2024-08-08-01-25-02.mp4iOS: NativeScreen.Recording.2024-08-07.at.11.57.26.PM.moviOS: mWeb SafariScreen.Recording.2024-08-08.at.12.35.04.AM.movMacOS: Chrome / SafariScreen.Recording.2024-08-07.at.10.55.15.PM.movMacOS: DesktopScreen.Recording.2024-08-08.at.9.24.24.PM.mov |
i'll priortize this for tomorrow 🙇 |
I just noticed we have lint check failing @bernhardoj |
Nevermind wrong branch 😅 |
Lint fixed. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
FYI I believe this was deployed to prod yesterday, from this checklist - #47219 |
Details
When we go back from the expense report using the parent link under the header title, the get newer actions is called. It's also called every time we scroll up and down.
Fixed Issues
$ #45227
PROPOSAL: #45227 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4