-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create description, merchant and reportID filters #46477
Create description, merchant and reportID filters #46477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
found you a few naming errors, but other than that code looks straightforward
offlineIndicatorStyle={styles.mtAuto} | ||
> | ||
<FullPageNotFoundView shouldShow={false}> | ||
<HeaderWithBackButton title={translate('common.date')} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy-paste error, fix translation
); | ||
} | ||
|
||
SearchFiltersDescriptionPage.displayName = 'SearchFiltersMerchantPage'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SearchFiltersDescriptionPage.displayName = 'SearchFiltersMerchantPage'; | |
SearchFiltersDescriptionPage.displayName = 'SearchFiltersDescriptionPage'; |
offlineIndicatorStyle={styles.mtAuto} | ||
> | ||
<FullPageNotFoundView shouldShow={false}> | ||
<HeaderWithBackButton title={translate('common.date')} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix translation
offlineIndicatorStyle={styles.mtAuto} | ||
> | ||
<FullPageNotFoundView shouldShow={false}> | ||
<HeaderWithBackButton title={translate('common.date')} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix translation
); | ||
} | ||
|
||
SearchFiltersReportIDPage.displayName = 'SearchFiltersMerchantPage'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SearchFiltersReportIDPage.displayName = 'SearchFiltersMerchantPage'; | |
SearchFiltersReportIDPage.displayName = 'SearchFiltersReportIDPage'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is looking good. Let's get this in review soon!
src/languages/es.ts
Outdated
@@ -358,6 +358,7 @@ export default { | |||
value: 'Valor', | |||
downloadFailedTitle: 'Error en la descarga', | |||
downloadFailedDescription: 'No se pudo completar la descarga. Por favor, inténtalo más tarde.', | |||
reportID: 'ID informe', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reportID: 'ID informe', | |
reportID: 'ID del informe', |
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Ready for review @luacmartins! |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.webmAndroid: mWeb Chromeandroid-mweb.webmiOS: Nativeios.mp4iOS: mWeb Safariios-mweb.mp4MacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly to #46197 (review), code and UI wise this is on point 🚀
The only thing that I found to be off with the functionality is that once a filter is applied, it doesn't seem to change anything in the search Expenses list compared to before the filter was applied.
For example the reviewer checklist Web video:
MacOS: Chrome / Safari
web.mov
Few other observations (NAB) but wanted to bring them up before merge:
- all 3 fields capitalize the value once added; this does not get passed to the filters URL - only shows capitalized UI
Report ID
field allows all characters (inc. non-numeric)
@luacmartins @SzymczakJ If this is expected for now, and will be fixed to actually work once all filter categories are implemented then we're good to go here 🟢, but if this is supposed to work differently than in the video shown above then I think it should be fixed here before merging.
@ikevin127 it's an expected result. We're just modifying URL, which later will be used to produce expected Expenses list, but BE is not ready yet. |
SCREENS.SEARCH.ADVANCED_FILTERS_MERCHANT_RHP, | ||
SCREENS.SEARCH.ADVANCED_FILTERS_REPORT_ID_RHP, | ||
SCREENS.SEARCH.ADVANCED_FILTERS_CATEGORY_RHP, | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @SzymczakJ Let's fix the capitalization of merchant and description in a follow up PR.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.16-0 🚀
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.16-8 🚀
|
Details
Fixed Issues
$ #46043
$ #46034
$ #46032
PROPOSAL: N/A
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
androidWeb.mov
iOS: Native
ios.mov
iOS: mWeb Safari
iosweb.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
dekstop.mov