Update onyx & Fix the enable-payments page

[parasharrajat]

Details

Fixed Issues

$ #4500
Fixes #4392

Tests | QA Steps

1. Navigate to staging.new.expensify.com/enable-payments.
2. Refresh the page

Tested On

• Web
• Mobile Web

Screenshots

Web

enable-payments.mp4

[parasharrajat]

This is straightforward PR which simply upgrade Onyx version.

[AndrewGable]

Looks good @parasharrajat - I am ready to merge when you fix merge conflicts

[AndrewGable]

🤔 - Now there are no changes

[parasharrajat]

@AndrewGable Looks like someone already updated the version. I don't think we have to merge this PR. There is nothing to merge and you can simply mark the issues completed to just notify that those are done.

[AndrewGable]

Can we confirm the fix is live first? Either on staging or locally?

[parasharrajat]

Ok, this is the PR #4610 which upgrades the Onyx. Looks like yet to be pushed to staging.

[parasharrajat]

Maybe it's better to merge so that QA can be done separately.

[AndrewGable]

Good point 👍

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @AndrewGable in version: 1.0.85-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[isagoico]

@marcaaron I guess the Deploy blocker label was added because of the blank page when navigating to enable-payments
Should I create a separate issue or is this already being addressed?

[marcaaron]

I don't think there is any need for a new issue.

[marcaaron]

i.e. both issues should be resolved once we fix the new blocker.

[parasharrajat]

I don't think that I have to do something here. Revert PR will fix the original issue as well.

[isagoico]

@marcaaron This issue is still reproducible in 1.0.86-2

[parasharrajat]

@isagoico the issue you are reporting now has a different cause than what we fixed.

[isagoico]

oh well I'll go ahead and create an issue for this one. Thanks Rajat!

[marcaaron]

There's no spinner anymore so it seems maybe a new issue? Not totally sure.

[isagoico]

Reported the issue here #4719

[botify]

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-01. 🎊

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[botify]

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-06. 🎊

[MitchExpensify]

No regressions mentioned here, paying in Upwork!