Centralize Onyx subscriptions in ReportScreen #4594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcaaron
changed the title
Fix the context methods more report screen organizing create more context helpers remove bad merged code remove unusued imports and fix style undo context changes remove unused line add missing session
marcaaron
force-pushed
the
marcaaron-reduceReportSubscriptions
branch
from
5c7635d
to
fd2f824
Compare
marcaaron
changed the title
marcaaron
commented
Aug 12, 2021
| @@ -26,7 +26,7 @@ export default (onyxKeyName) => { | |||
| }, | |||
| })(Provider); | |||
|
|
|||
| const withOnyxKey = ({propName = onyxKeyName, transformValue = () => {}} = {}) => (WrappedComponent) => { | |||
| const withOnyxKey = ({propName = onyxKeyName, transformValue} = {}) => (WrappedComponent) => { | |||
There was a problem hiding this comment.
This is unrelated but fixes an issue where we only return the value if the function is undefined but by defaulting to an anonymous function that never happens.
marcaaron
changed the title
MelvinBot
requested review from
stitesExpensify
and removed request for
a team
stitesExpensify
approved these changes
Aug 13, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Aug 16, 2021
|
🚀 Deployed to staging by @marcaaron in version: 1.0.85-10 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR should improve report switching time a bit since
withOnyx()HOCs are fairly expensive to initialize and we can reduce the number of keys we subscribe to by passing some props to theReportScreenchildren instead of creating duplicate subscriptions.Fixed Issues
Not really related to any particular issue - we are trying to improve chat switch metrics and there's a tracking issue here:
#4022
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android